[coreboot-gerrit] [S] Change in coreboot[main]: mb/google/brox: Reduce PL values for booting without battery

[Sowmya Aralguppe (Code Review)]

Attention is currently required from: Ashish Kumar Mishra, Deepti Deshatty, Eric Herrmann, Karthik Ramasubramanian, Shelley Chen.

Sowmya Aralguppe has posted comments on this change by Sowmya Aralguppe. ( https://review.coreboot.org/c/coreboot/+/83406?usp=email )

Change subject: mb/google/brox: Reduce PL values for booting without battery
......................................................................

Patch Set 6:

(2 comments)

This change is ready for review.

File src/mainboard/google/brox/variants/baseboard/brox/ramstage.c:

https://review.coreboot.org/c/coreboot/+/83406/comment/e61afefb_6725e22c?usp... :
PS2, Line 161: 	soc_config->tdp_pl4 -= POWER_LIMIT_TUNE;
> Yes this intentional . […]

Acknowledged

File src/mainboard/google/brox/variants/baseboard/brox/ramstage.c:

https://review.coreboot.org/c/coreboot/+/83406/comment/04066cac_c7401902?usp... :
PS4, Line 96:  * +-------------+-----+------+---------+-------+
            :  * | Max Power(W)| TDP | PL2  | PsysPL2 | PL3/4 |
            :  * +-------------+-----+------+---------+-------+
            :  * |     30      |  15 |  17  |   25    |  25   | <--- not working yet
            :  * |     45      |  15 |  26  |   38    |  38   |
            :  * |     60      |  15 |  35  |   51    |  51   |
            :  * |    110      |  15 |  55  |   94    |  96   |
            :  * +-------------+-----+------+---------+-------+
            :  */
> can you please adjust the table to reflect the updated values below?

Done