[coreboot-gerrit] Change in coreboot[master]: mb/google/dedede: Add SD card support

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39237 )

Change subject: mb/google/dedede: Add SD card support
......................................................................

Patch Set 26:

(2 comments)

https://review.coreboot.org/c/coreboot/+/39237/23/src/mainboard/google/deded... 
File src/mainboard/google/dedede/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/39237/23/src/mainboard/google/deded... 
PS23, Line 284: GPP_G7
> Do you understand what the errors mean? And how GPP_G7/SD_SDIO_WP was causing those?

Still to check on that. I'll check and update.

https://review.coreboot.org/c/coreboot/+/39237/26/src/mainboard/google/deded... 
File src/mainboard/google/dedede/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/39237/26/src/mainboard/google/deded... 
PS26, Line 387: DEEP
> Should this pad reset config align with the Card detect GPIO GPP_G5 i.e. […]

It should align with the G5, I'll check test and update.