Attention is currently required from: Wonkyu Kim, Arthur Heymans.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55197 )
Change subject: cpu/x86/mp_init: Support both xapic and x2apic with common code
......................................................................
Patch Set 3:
(1 comment)
File src/cpu/x86/mp_init.c:
https://review.coreboot.org/c/coreboot/+/55197/comment/80c67edc_a96904c5
PS3, Line 664: /* FIXME: Why the difference? */
I'd like to write in the commit message why/if this is the correct thing to do.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55197
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7264f39143cc6edb7a9687d0bd763cb2703a8265
Gerrit-Change-Number: 55197
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 04 Jun 2021 20:55:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment