Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38714 )
Change subject: trogdor: latching GPIO interrupt support
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38714/3/src/mainboard/google/trogdo...
File src/mainboard/google/trogdor/chromeos.c:
https://review.coreboot.org/c/coreboot/+/38714/3/src/mainboard/google/trogdo...
PS3, Line 53: GPIO_H1_AP_INT
...and what about gpio_input_irq()? It's not going to initialize itself... (should be done in bootblock_mainboard_init()).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38714
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8198213cf2808be5291620892185b1e534263e3f
Gerrit-Change-Number: 38714
Gerrit-PatchSet: 3
Gerrit-Owner: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Thu, 06 Feb 2020 02:04:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment