Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33380 )
Change subject: Console: Allow console UART to be enabled without serial console
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33380/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/33380/1//COMMIT_MSG@14
PS1, Line 14: TEST=Verify UART still works, even with coreboot console disabled
Did you test that it doesn't work without this change and coreboot
console disabled? If so, what was the exact issue?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33380
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0942634ab8a9fcafdc1ea099721c127202e9f9a
Gerrit-Change-Number: 33380
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Tue, 11 Jun 2019 16:37:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment