Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37168 )
Change subject: sb/amd/{agesa,pi}/hudson: add southbridge C bootblock initialization
......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37168/9/src/southbridge/amd/agesa/h...
File src/southbridge/amd/agesa/hudson/early_setup.c:
https://review.coreboot.org/c/coreboot/+/37168/9/src/southbridge/amd/agesa/h...
PS9, Line 93: = 0
dead assignment
https://review.coreboot.org/c/coreboot/+/37168/9/src/southbridge/amd/agesa/h...
PS9, Line 97: tmp = DECODE_ENABLE_PARALLEL_PORT0 | DECODE_ENABLE_PARALLEL_PORT2
This might look better with shorter macro names. As it is, currently, I'd understand an hex number more easily
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37168
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaba5443d8770473c4abe73ec2a91f8d6a52574af
Gerrit-Change-Number: 37168
Gerrit-PatchSet: 9
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 30 Nov 2019 15:57:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment