Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31848 )
Change subject: nb/amd/amdfam10/util.c: Use "CONFIG" only when appropriate
......................................................................
Patch Set 1: Code-Review+1
According to MAINTAINERS I think(?) Tim Pearson is managing these? Not sure why Gerrit didn't auto-CC him.
I'm okay with this change, but I also don't want to change someone else's log output without asking. This is technically a bug in the linter, not the code, but if nobody cares about the exact wording in the log output this would be an easy way to get rid of a spurious warning.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31848
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idcdbbfa883c906db1ebb8d9bc7c9e277e7c0c949
Gerrit-Change-Number: 31848
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Timothy Pearson
tpearson@raptorengineering.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 11 Mar 2019 21:16:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment