Ravi Chandra Sadineni has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34801 )
Change subject: chromeec: Depend on events_copy_b to identify the wake source ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34801/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34801/4//COMMIT_MSG@7 PS4, Line 7: ec/google/chromeec: Depend on events_copy_b to identify the wake source.
Please remove the dot at the end of the commit message summary.
Done
https://review.coreboot.org/c/coreboot/+/34801/4//COMMIT_MSG@13 PS4, Line 13:
Can you please elaborate on the problem that is solved?
Will the additional details I added help. Please let me know if it still does not make sense.
https://review.coreboot.org/c/coreboot/+/34801/4/src/ec/google/chromeec/ec.c File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/34801/4/src/ec/google/chromeec/ec.c... PS4, Line 431: u64
nit: uint64_t
Done
https://review.coreboot.org/c/coreboot/+/34801/4/src/ec/google/chromeec/ec.c... PS4, Line 439: /* : * If the EC supports unified wake masks, then there is no need to set : * wake mask before reading out the host events. : */ : if (google_chromeec_check_feature(EC_FEATURE_UNIFIED_WAKE_MASKS) != 1) { : wake_mask = google_chromeec_get_wake_mask(); : google_chromeec_set_wake_mask(mask); : restore_wake_mask = true; : } :
Now that we are relying on events_copy_b there is no need to do this setting/restoring of wake masks […]
My bad. removed this code now.