Eric Peers has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47719 )
Change subject: mb/google/zork: Remove 50ms WIFI delay
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47719/1/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c:
https://review.coreboot.org/c/coreboot/+/47719/1/src/mainboard/google/zork/v...
PS1, Line 213: mdelay(50);
in order to guarantee the mdelay, do we need to set a timer and inject a delay later? I would guess it would never trigger, but there's nothing in the ramstage that's explicitly guaranteeing this contract right?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47719
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I211d3da338ad368d1f011f03cf7d05121c057075
Gerrit-Change-Number: 47719
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 18 Nov 2020 17:54:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment