SH Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34581 )
Change subject: mb/google/kohaku: Enable stylus pen device ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34581/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34581/1//COMMIT_MSG@13 PS1, Line 13: TEST=Verified pen input operation and pen detection event
Did pen eject work to: […]
1. Show the stylus tools on eject ; Yes 2. Hide the stylus tools on insert ; Yes 3. Wake from pen eject from S0ix and S3 (Did the eventlog have right information?) ; Yes. (Tested on s0ix) But there is no wake source in eventlog. Should we have the wake source in event log? 4. No wake by pen insert from S0ix and S3. ; Yes. (tested on s0ix)
https://review.coreboot.org/c/coreboot/+/34581/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/gpio.c:
https://review.coreboot.org/c/coreboot/+/34581/1/src/mainboard/google/hatch/... PS1, Line 49:
Why was this removed? Is it not required anymore?
It was routed to EMR_GARAGE_INT before, but not used. GPP_C12 would be routed to EN_PP3300_TSP_DX in latest schematics, we need to configure it in another CL for enabling TSP device.
https://review.coreboot.org/c/coreboot/+/34581/1/src/mainboard/google/hatch/... PS1, Line 27: 1
Note: This should be set to 0 if you figure out that the reset GPIO needs to be part of power sequen […]
As our device charger checked with wacom, they said we don't need triggering reset for power sequencing of the IC. When the IC powered on, reset would be triggered internally. So I think we can keep this signal as high or route to always on power.
https://review.coreboot.org/c/coreboot/+/34581/1/src/mainboard/google/hatch/... PS1, Line 43: NONE
INVERT
Done