6 Sep
2021
6 Sep
'21
1:33 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57346 )
Change subject: mb/intel/leafhill,minnow3: remove ADD_FSP_BINARIES config override ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
there are also some other things i found in the fsp driver's Kconfig that could be improved, but not […]
There'll always be room for improvement left. After all, we have been cleaning up this area for about 3 years already, still what you encountered was easy to improve. Thanks for taking the time! it already looks much better now
--
To view, visit https://review.coreboot.org/c/coreboot/+/57346
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I23439f3134eef9460625addbff7efd64c5f65ae5
Gerrit-Change-Number: 57346
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-CC: Martin Roth martinroth@google.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Comment-Date: Mon, 06 Sep 2021 11:33:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Martin Roth martinroth@google.com
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment