[coreboot-gerrit] Change in ...coreboot[master]: cpu/intel/microcode: Enable verbose output

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/29864 )

Change subject: cpu/intel/microcode: Enable verbose output
......................................................................

cpu/intel/microcode: Enable verbose output

* Check if microcode is really updated.
* Enable more verbose output.

Change-Id: I534aa790c8d37b5f1603e1715635446835513a65
Signed-off-by: Philipp Deppenwiese 
Reviewed-on: https://review.coreboot.org/c/29864
Tested-by: build bot (Jenkins) 
Reviewed-by: Patrick Rudolph 
Reviewed-by: David Hendricks 
---
M src/cpu/intel/microcode/microcode.c
1 file changed, 14 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  David Hendricks: Looks good to me, approved
  Patrick Rudolph: Looks good to me, but someone else must approve

diff --git a/src/cpu/intel/microcode/microcode.c b/src/cpu/intel/microcode/microcode.c
index abaeeb6..44f7f1f 100644
--- a/src/cpu/intel/microcode/microcode.c
+++ b/src/cpu/intel/microcode/microcode.c
@@ -88,8 +88,12 @@
    current_rev = read_microcode_rev();

/* No use loading the same revision. */
-	if (current_rev == m->rev)
+	if (current_rev == m->rev) {
+#if !defined(__ROMCC__)
+		printk(BIOS_INFO, "microcode: Update skipped, already up-to-date\n");
+#endif
    	return;
+	}

#if ENV_RAMSTAGE
    /*SoC specific check to update microcode*/
@@ -103,12 +107,20 @@
    msr.hi = 0;
    wrmsr(IA32_BIOS_UPDT_TRIG, msr);

+	current_rev = read_microcode_rev();
+	if (current_rev == m->rev) {
 #if !defined(__ROMCC__)
-	printk(BIOS_DEBUG, "microcode: updated to revision "
+		printk(BIOS_INFO, "microcode: updated to revision "
    	    "0x%x date=%04x-%02x-%02x\n", read_microcode_rev(),
    	    m->date & 0xffff, (m->date >> 24) & 0xff,
    	    (m->date >> 16) & 0xff);
 #endif
+		return;
+	}
+
+#if !defined(__ROMCC__)
+	printk(BIOS_INFO, "microcode: Update failed\n");
+#endif
 }

uint32_t get_current_microcode_rev(void)