Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47192 )
Change subject: mb/purism/librem_mini: Adjust GPIO reset values ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1: Code-Review-1
When the hex values are the values read from the registers, the reset values are already correct.
These have been adjusted as per schematics, since vendor firmware values don't make much sense. But I agree that the raw values are now useless.
Where talking about reset values here. There's not much in schematics, that helps you choose them (except that you know what a specific gpio is used for). Reset values depend on which gpios must function in lower power states like S3. That could be EC stuff for example, that must not be reset to prevent braking wake.
The point confusing me here is that the new values are exactly the hex values with reverse-mapping from rst_map* applied, which makes me guess there happened some mistake somewhere. So I wonder how exactly the new values have been chosen.