Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38549 )
Change subject: mainboard/ocp: Add support for OCP platform TiogaPass
......................................................................
Patch Set 9:
(1 comment)
Rebased to upstream tip:
e4d6c033fe (origin/master, origin/HEAD) Doc/mb/lenovo: Shrink picture for x301
Tested on TiogaPass server without regression observed.
https://review.coreboot.org/c/coreboot/+/38549/9/src/mainboard/ocp/tiogapass...
File src/mainboard/ocp/tiogapass/acpi_tables.c:
https://review.coreboot.org/c/coreboot/+/38549/9/src/mainboard/ocp/tiogapass...
PS9, Line 18: #include <types.h>
: #include <string.h>
: #include <arch/acpi.h>
: #include <arch/ioapic.h>
: #include <arch/acpigen.h>
: #include <arch/smp/mpspec.h>
: #include <device/device.h>
: #include <device/pci.h>
: #include <cpu/x86/msr.h>
:
: #include <intelblocks/acpi.h>
: #include <soc/acpi.h>
: #include <soc/nvs.h>
Please include only what you use. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38549
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29868f03037d1887b90dfb19d15aee83c456edce
Gerrit-Change-Number: 38549
Gerrit-PatchSet: 9
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Petrov
anpetrov@fb.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 27 Jan 2020 21:31:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment