Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36071 )
Change subject: superio: IT8587E (WIP) ......................................................................
Patch Set 2:
(2 comments)
i'm not sure which comment belongs to which line; would be good if all comments were in the line above the code line they refer to
https://review.coreboot.org/c/coreboot/+/36071/2/src/superio/ite/it8587e/sup... File src/superio/ite/it8587e/superio.c:
https://review.coreboot.org/c/coreboot/+/36071/2/src/superio/ite/it8587e/sup... PS2, Line 28: { does it need the keyboard init most other SIO chips have here?
https://review.coreboot.org/c/coreboot/+/36071/2/src/superio/ite/it8587e/sup... PS2, Line 49: Program io0 = 0x70-0x73 the mask for io0 contradicts this, since it if only for a 2 byte io space and not a 4 byte one.
or did you write the comment below the line it refers to? i'd expect that the comment refers to the line below it? at least for IT8587E_KBCK the comment is above the line it refers to