build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30917 )
Change subject: soc/intel/cannonlake: Change in SaGv options ......................................................................
Patch Set 4:
(7 comments)
https://review.coreboot.org/#/c/30917/4/src/soc/intel/cannonlake/chip.h File src/soc/intel/cannonlake/chip.h:
https://review.coreboot.org/#/c/30917/4/src/soc/intel/cannonlake/chip.h@103 PS4, Line 103: * When enabled memory will be training at two or three different frequencies. line over 80 characters
https://review.coreboot.org/#/c/30917/4/src/soc/intel/cannonlake/chip.h@104 PS4, Line 104: * for CNL options are as following trailing whitespace
https://review.coreboot.org/#/c/30917/4/src/soc/intel/cannonlake/chip.h@104 PS4, Line 104: * for CNL options are as following code indent should use tabs where possible
https://review.coreboot.org/#/c/30917/4/src/soc/intel/cannonlake/chip.h@105 PS4, Line 105: * 0:Disabled, 1:FixedLow, 2:FixedMid, 3:FixedHigh, 4:Enabled trailing whitespace
https://review.coreboot.org/#/c/30917/4/src/soc/intel/cannonlake/chip.h@106 PS4, Line 106: * for others options are as following trailing whitespace
https://review.coreboot.org/#/c/30917/4/src/soc/intel/cannonlake/chip.h@106 PS4, Line 106: * for others options are as following code indent should use tabs where possible
https://review.coreboot.org/#/c/30917/4/src/soc/intel/cannonlake/chip.h@107 PS4, Line 107: * 0:Disabled, 1:FixedLow, 2:FixedHigh, 3:Enabled*/ code indent should use tabs where possible