Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40334 )
Change subject: configs/builder/config.ocp.sonorapass: Config for SonoraPass PO. src/mainboard/ocp/sonorapass/*.*: Preliminary platform porting for SonoraPass PO. ......................................................................
Patch Set 2:
(14 comments)
https://review.coreboot.org/c/coreboot/+/40334/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40334/2//COMMIT_MSG@12 PS2, Line 12: Change-Id: I60452205d666fd19582780401ccd9d7773e68a5b please add Signed-off-by line in commit message
https://review.coreboot.org/c/coreboot/+/40334/2/configs/builder/config.ocp.... File configs/builder/config.ocp.sonorapass:
PS2: It is better to do this in a separate patch. See CB:39783
https://review.coreboot.org/c/coreboot/+/40334/2/configs/builder/config.ocp.... PS2, Line 12: cedarisland_crb sonorapass
https://review.coreboot.org/c/coreboot/+/40334/2/configs/builder/config.ocp.... PS2, Line 13: cedarisland_crb sonorapass
https://review.coreboot.org/c/coreboot/+/40334/2/configs/builder/config.ocp.... PS2, Line 14: cedarisland_crb sonorapass
https://review.coreboot.org/c/coreboot/+/40334/2/src/mainboard/ocp/sonorapas... File src/mainboard/ocp/sonorapass/bootblock.c:
https://review.coreboot.org/c/coreboot/+/40334/2/src/mainboard/ocp/sonorapas... PS2, Line 16: tab
https://review.coreboot.org/c/coreboot/+/40334/2/src/mainboard/ocp/sonorapas... PS2, Line 17: tab
https://review.coreboot.org/c/coreboot/+/40334/2/src/mainboard/ocp/sonorapas... PS2, Line 18: tab
https://review.coreboot.org/c/coreboot/+/40334/2/src/mainboard/ocp/sonorapas... PS2, Line 19: tab
https://review.coreboot.org/c/coreboot/+/40334/2/src/mainboard/ocp/sonorapas... PS2, Line 25: please use tab
https://review.coreboot.org/c/coreboot/+/40334/2/src/mainboard/ocp/sonorapas... PS2, Line 26: please use tabs in all such cases
https://review.coreboot.org/c/coreboot/+/40334/2/src/mainboard/ocp/sonorapas... PS2, Line 78: tab
https://review.coreboot.org/c/coreboot/+/40334/2/src/mainboard/ocp/sonorapas... PS2, Line 80: tab
https://review.coreboot.org/c/coreboot/+/40334/2/src/mainboard/ocp/sonorapas... PS2, Line 81: tab