Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31331 )
Change subject: mb/google/sarien/variants/arcada: Update thermal configuration for DPTF ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/#/c/31331/2/src/mainboard/google/sarien/variants... File src/mainboard/google/sarien/variants/arcada/include/variant/acpi/dptf.asl:
https://review.coreboot.org/#/c/31331/2/src/mainboard/google/sarien/variants... PS2, Line 23: 108 Please, explain why it's set such a high value 108 for Skin sensor ?
https://review.coreboot.org/#/c/31331/2/src/mainboard/google/sarien/variants... PS2, Line 35: 95 Please, explain why it's set such a high value 95 for Ambient sensor ?
https://review.coreboot.org/#/c/31331/2/src/mainboard/google/sarien/variants... PS2, Line 60: 21 What's the reason for reducing it from previous value of 25W to this new value as 21W ? Did you observe any issue with previous value ?
https://review.coreboot.org/#/c/31331/2/src/mainboard/google/sarien/variants... PS2, Line 62: 28000 How did you arrive to this particular number ?
https://review.coreboot.org/#/c/31331/2/src/mainboard/google/sarien/variants... PS2, Line 70: 28000 same query as previous one.