Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35558 )
Change subject: device/dram/ddr4: Check if total or used SPD bytes value is reserved ......................................................................
Patch Set 8: Code-Review+2
(1 comment)
The commit message looks like badly formatted code in my browser:
device/dram/ddr4: Check if total or used SPD bytes value is reserved
The value stored to 'spd_bytes_total' is never read, so let use it to check if 'SPD Bytes Total' and/or 'SPD Bytes Used' are reserved. If 'SPD Bytes Used' value is reserved, then return SPD_STATUS_INVALID as it causes an out of bound access. Add a sanity check if used bytes is greater than the total number of bytes.
Please! If you want to make a list, make a list. If you want to write a paragraph, don't add linebreaks after every full stop. And if you want it to be viewable in standard programs (like Gerrit), obey the 72-chars-per-line rule of Git.
https://review.coreboot.org/c/coreboot/+/35558/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35558/8//COMMIT_MSG@10 PS8, Line 10: and/or 'SPD Bytes Used' this is not really what is happening, `spd_bytes_total` is obviously _not_ used to check if `SPD Bytes Used` is reserved.