Tim Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47013 )
Change subject: mb/google/dedede/var/metaknight: Add device settings ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47013/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47013/1//COMMIT_MSG@14 PS1, Line 14: 5. Add WiFi configuration
Is metaknight using Discrete WiFi or CNVi?
metaknight is using CNVi.
https://review.coreboot.org/c/coreboot/+/47013/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/metaknight/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/47013/1/src/mainboard/google/dedede... PS1, Line 106: "ACPI_IRQ_WAKE_EDGE_LOW(GPP_B3_IRQ)"
We recently learnt that HID over I2C uses Level triggered IRQs. So needs to be fixed. […]
I should change this to ACPI_IRQ_WAKE_LEVEL_LOW(GPP_B3_IRQ) right?