Attention is currently required from: Balaji Manigandan, Martin L Roth, Saurabh Mishra, Saurabh Mishra.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80463?usp=email )
Change subject: drivers/soundwire/ALC722: Add ALC722 codec support
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80463/comment/9658fe79_954c3f54 :
PS1, Line 8:
please add a bug to start with.
File src/drivers/soundwire/alc722/Kconfig:
https://review.coreboot.org/c/coreboot/+/80463/comment/16c036f2_e9e1c6ae :
PS1, Line 1: config DRIVERS_SOUNDWIRE_ALC722
: bool
:
why not having a help text ?
File src/include/mipi/ids.h:
https://review.coreboot.org/c/coreboot/+/80463/comment/08de725d_581810fe :
PS1, Line 25: #define MIPI_DEV_ID_REALTEK_ALC722 0x0722
should this sit next to line 23? (i.e., at line 24)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80463?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6dfa1b8cc6bec8f227083e161a6ee876c91808d2
Gerrit-Change-Number: 80463
Gerrit-PatchSet: 1
Gerrit-Owner: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Saurabh Mishra
mishra.saurabh@intel.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Saurabh Mishra
100rabah@gmail.com
Gerrit-Attention: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Attention: Saurabh Mishra
mishra.saurabh@intel.corp-partner.google.com
Gerrit-Comment-Date: Mon, 18 Mar 2024 07:49:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment