Attention is currently required from: Stefan Reinauer.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73487 )
Change subject: util/ifdtool: Add option to create FMAP template ......................................................................
Patch Set 1:
(3 comments)
File util/ifdtool/ifdtool.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171453): https://review.coreboot.org/c/coreboot/+/73487/comment/3655b63a_60c008b8 PS1, Line 1005: S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); Symbolic permissions 'S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH' are not preferred. Consider using octal permissions '0644'.
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171453): https://review.coreboot.org/c/coreboot/+/73487/comment/e0538bcb_aea3e3d6 PS1, Line 1011: char *lbuf = "FLASH@##ROM_BASE## ##ROM_SIZE## {\n" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171453): https://review.coreboot.org/c/coreboot/+/73487/comment/7a8c747b_ff94dad7 PS1, Line 1040: if (write(layout_fd, "}", 1) < 0 ) { space prohibited before that close parenthesis ')'