Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40421 )
Change subject: soc/amd/picasso: Add SPI speed devicetree settings and EM100 support
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40421/3/src/soc/amd/picasso/southbr...
File src/soc/amd/picasso/southbridge.c:
https://review.coreboot.org/c/coreboot/+/40421/3/src/soc/amd/picasso/southbr...
PS3, Line 288: sb_spi_init
I think this function is executed too late. […]
fch_pre_init() is called as part of bootblock as per https://review.coreboot.org/c/coreboot/+/37490/13/src/soc/amd/picasso/bootbl.... So this should still work fine.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40421
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I24c27ec39101c7c07bedc27056f690cf2cc54951
Gerrit-Change-Number: 40421
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Tue, 28 Apr 2020 00:44:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment