Thejaswani Putta has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35509 )
Change subject: mb/google/drallion: Disable GBE in firmware for drallion variants
......................................................................
Patch Set 3:
(2 comments)
Patch Set 3:
Shouldn't this be on the drallion variant not sarien_cml?
1f.6 is already disabled in arcada_cml and drallion variant. Sarien_cml is the only variant where it is still ON. so disabling the same.
https://review.coreboot.org/c/coreboot/+/35509/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35509/3//COMMIT_MSG@8
PS3, Line 8:
Why? Is there no interface?
No, this is not a POR for drallion.
https://review.coreboot.org/c/coreboot/+/35509/3//COMMIT_MSG@10
PS3, Line 10: Cbmem
CBMEM
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35509
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e74b259ce8f5f70833dce94692dcbe33e8504db
Gerrit-Change-Number: 35509
Gerrit-PatchSet: 3
Gerrit-Owner: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: AndreX Andraos
andrex.andraos@intel.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Chiranjeevi Rapolu
chiranjeevi.rapolu@intel.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Thejaswani Putta
thejaswani.putta@intel.corp-partner.google.com
Gerrit-Reviewer: Varun Joshi
varun.joshi@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 25 Sep 2019 18:37:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment