Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39040 )
Change subject: soc/intel/tigerlake: add DDR4 support ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39040/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39040/4//COMMIT_MSG@13 PS4, Line 13: TEST= build tglrvp flash and boot to kernel With what DDR4 configuration?
https://review.coreboot.org/c/coreboot/+/39040/4/src/soc/intel/tigerlake/inc... File src/soc/intel/tigerlake/include/soc/meminit_tgl.h:
https://review.coreboot.org/c/coreboot/+/39040/4/src/soc/intel/tigerlake/inc... PS4, Line 87: const struct mb_ddr4x_cfg *mem_cfg_data); Should fit on one line.
https://review.coreboot.org/c/coreboot/+/39040/4/src/soc/intel/tigerlake/mem... File src/soc/intel/tigerlake/meminit_tgl.c:
https://review.coreboot.org/c/coreboot/+/39040/4/src/soc/intel/tigerlake/mem... PS4, Line 174: const struct mb_ddr4x_cfg *mem_cfg_data) Should fit on one line.