Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86134?usp=email )
Change subject: mb/starlabs/byte_adl: Disconnect unused GPIOs ......................................................................
mb/starlabs/byte_adl: Disconnect unused GPIOs
Change-Id: Ie4c2c32c0740e2ad763881f3f4d5920387f49c79 Signed-off-by: Sean Rhodes sean@starlabs.systems Reviewed-on: https://review.coreboot.org/c/coreboot/+/86134 Reviewed-by: Matt DeVillier matt.devillier@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c 1 file changed, 10 insertions(+), 10 deletions(-)
Approvals: Matt DeVillier: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c b/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c index ecd4082..f17e3ae 100644 --- a/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c +++ b/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c @@ -27,11 +27,11 @@ /* GPD3: Power Button */ PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), /* GPD4: Sleep S3 */ - PAD_CFG_NF(GPD4, NONE, DEEP, NF1), + PAD_NC(GPD4, NONE), /* GPD5: Sleep S4 */ - PAD_CFG_NF(GPD5, NONE, DEEP, NF1), + PAD_NC(GPD5, NONE), /* GPD6: Sleep A */ - PAD_CFG_NF(GPD6, NONE, DEEP, NF1), + PAD_NC(GPD6, NONE), /* GPD7: Power Adapter Disable */ PAD_CFG_GPO(GPD7, 0, PWROK), /* GPD8: Suspend Clock */ @@ -39,7 +39,7 @@ /* GPD9: Wireless LAN Sleep */ PAD_CFG_NF(GPD9, NONE, DEEP, NF1), /* GPD10: Sleep S5 */ - PAD_CFG_NF(GPD10, NONE, DEEP, NF1), + PAD_NC(GPD10, NONE), /* GPD11: LAN PHY Enable */ PAD_NC(GPD11, NONE),
@@ -58,7 +58,7 @@ PAD_NC(GPP_A8, NONE), /* A9: ESPI Clock */ /* A10: ESPI Reset */ - /* A11: Not Connected */ + /* A11: Webcam Camera Reset */ PAD_NC(GPP_A11, NONE), /* A12: PCH M.2 SSD PEDET */ PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1), @@ -111,7 +111,7 @@ /* B11: I2C PMC PD Interrupt Test Point 28 */ PAD_CFG_NF(GPP_B11, NONE, DEEP, NF1), /* B12: PM SLP S0 */ - PAD_CFG_NF(GPP_B12, NONE, DEEP, NF1), + PAD_NC(GPP_B12, NONE), /* B13: PLT RST */ PAD_CFG_NF(GPP_B13, NONE, DEEP, NF1), /* B14: Top Swap Override Weak Internal PD 20K @@ -265,8 +265,8 @@ PAD_NC(GPP_E11, NONE), /* E12: Touchpad Interrupt */ PAD_NC(GPP_E12, NONE), - /* E13: PWD Amplifier Input */ - PAD_CFG_GPO(GPP_E13, 0, PLTRST), + /* E13: Not connected */ + PAD_NC(GPP_E13, NONE), /* E14: EDP HPD */ PAD_CFG_NF(GPP_E14, NONE, DEEP, NF1), /* E15: Not Connected LAN RESET */ @@ -342,7 +342,7 @@ /* H0: PCH M.2 SSD Reset */ PAD_CFG_GPO_GPIO_DRIVER(GPP_H0, 1, PLTRST, NONE), /* H1: BFX Strap 2 Bit 3 Weak Internal PD 20K */ - PAD_CFG_GPO(GPP_H1, 1, PLTRST), + PAD_CFG_GPO(GPP_H1, 0, DEEP), /* H2: Wireless LAN Reset */ PAD_CFG_GPO(GPP_H2, 1, PLTRST), /* H3: Not Connected */ @@ -362,7 +362,7 @@ /* H12: Not Connected */ PAD_NC(GPP_H12, NONE), /* H13: PCH M.2 SSD Device Sleep */ - PAD_CFG_NF(GPP_H13, NONE, DEEP, NF5), + PAD_NC(GPP_H13, NONE), /* H14: Not Connected */ PAD_NC(GPP_H14, NONE), /* H15: DDPB Control Clock */