Stephen Boyd has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35499 )
Change subject: sc7180: Add QUPv3 FW load & config ......................................................................
Patch Set 15:
(8 comments)
https://review.coreboot.org/c/coreboot/+/35499/15/src/soc/qualcomm/sc7180/qu... File src/soc/qualcomm/sc7180/qupv3_config.c:
https://review.coreboot.org/c/coreboot/+/35499/15/src/soc/qualcomm/sc7180/qu... PS15, Line 19: se_mappings Is this supposed to be static?
https://review.coreboot.org/c/coreboot/+/35499/15/src/soc/qualcomm/sc7180/qu... PS15, Line 22: Pen Detect I2C This is EDP Bridge I2C
https://review.coreboot.org/c/coreboot/+/35499/15/src/soc/qualcomm/sc7180/qu... PS15, Line 23: Speaker Amps I2C This is Pen Detect and Touch I2C
https://review.coreboot.org/c/coreboot/+/35499/15/src/soc/qualcomm/sc7180/qu... PS15, Line 23: {QUPV3_0_SE4, SE_PROTOCOL_I2C, MIXED}, /* Speaker Amps I2C */ There should be another entry here for QUPV3_0_SE5 with i2c protocol /* SAR I2C */
https://review.coreboot.org/c/coreboot/+/35499/15/src/soc/qualcomm/sc7180/qu... PS15, Line 28: Fingerprint EC
https://review.coreboot.org/c/coreboot/+/35499/15/src/soc/qualcomm/sc7180/qu... PS15, Line 29: Touch Trackpad, not touch
https://review.coreboot.org/c/coreboot/+/35499/15/src/soc/qualcomm/sc7180/qu... PS15, Line 30: EDP Bridge Speaker Amps
https://review.coreboot.org/c/coreboot/+/35499/15/src/soc/qualcomm/sc7180/qu... PS15, Line 31: EC Fingerprint