Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44037 )
Change subject: sconfig: Allow chipset to provide a base devicetree ......................................................................
Patch Set 10:
(6 comments)
https://review.coreboot.org/c/coreboot/+/44037/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44037/9//COMMIT_MSG@15 PS9, Line 15: device
Because of the way things are organized and compared in sconfig (matching devices using chip to en […]
Added these to my todo list: Add better devtree docs and cleaning up SoC and chip drivers at unusual levels in the hierarchy.
https://review.coreboot.org/c/coreboot/+/44037/9/Makefile.inc File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/44037/9/Makefile.inc@16 PS9, Line 16: CONFIG_CHIPSET_DEVICETREE
Shouldn't this config option be added to src/Kconfig in this CL?
Ack
https://review.coreboot.org/c/coreboot/+/44037/9/Makefile.inc@607 PS9, Line 607: $(src)/
The expectation is that the chipset devicetree path should be relative to src/ directory. […]
Ack
https://review.coreboot.org/c/coreboot/+/44037/9/util/sconfig/main.c File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/44037/9/util/sconfig/main.c@713 PS9, Line 713: base_root_dev
We might need that if devices are added/defined only in the overridetree and also referenced there?
That was my plan, see CB:45878, where 'conn0' and 'conn1' are defined as aliases (and used only) in the overridetree
https://review.coreboot.org/c/coreboot/+/44037/9/util/sconfig/main.c@1763 PS9, Line 1763: parse_override_devicetree
Talked to Duncan and Tim offline. […]
Ack
https://review.coreboot.org/c/coreboot/+/44037/9/util/sconfig/sconfig.h File util/sconfig/sconfig.h:
https://review.coreboot.org/c/coreboot/+/44037/9/util/sconfig/sconfig.h@136 PS9, Line 136: devnum
It would be helpful to have a comment indicating what this really is.
Done