Attention is currently required from: Angel Pons, Federico Amedeo Izzo.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82010?usp=email )
Change subject: mb/aoostar: Add AOOSTAR R1 (WTR_R1) ......................................................................
Patch Set 9:
(9 comments)
File src/mainboard/aoostar/wtr_r1/Kconfig:
https://review.coreboot.org/c/coreboot/+/82010/comment/b62c67cf_0bbf71bd : PS8, Line 28: config MAINBOARD_VENDOR : string : default "AOOSTAR"
Already set in vendor Kconfig, please drop
Done
File src/mainboard/aoostar/wtr_r1/devicetree.cb:
PS9: Missing SPDX license identifier.
https://review.coreboot.org/c/coreboot/+/82010/comment/b0f5669e_f8c22532 : PS9, Line 11: # FSP configuration Remove superfluous comment
https://review.coreboot.org/c/coreboot/+/82010/comment/d03b5d0c_45267cc2 : PS9, Line 13: # Sagv Configuration Same
https://review.coreboot.org/c/coreboot/+/82010/comment/fc97702d_4b2701f1 : PS9, Line 16: # Enable DPTF Same
https://review.coreboot.org/c/coreboot/+/82010/comment/9fbaaf6f_6fc24f56 : PS9, Line 21: # Intel Common SoC Config Same
https://review.coreboot.org/c/coreboot/+/82010/comment/61dc3950_db4e298e : PS9, Line 74: register "usb2_ports[6]" = "USB2_PORT_EMPTY" Not needed, remove.
https://review.coreboot.org/c/coreboot/+/82010/comment/d93b905c_01c99ce6 : PS9, Line 79: register "usb3_ports[2]" = "USB3_PORT_EMPTY" : register "usb3_ports[3]" = "USB3_PORT_EMPTY" : register "usb3_ports[4]" = "USB3_PORT_EMPTY" Not needed, remove.
https://review.coreboot.org/c/coreboot/+/82010/comment/af4b56e9_f267dd5e : PS9, Line 85: register "tcss_ports[0]" = "TCSS_PORT_DEFAULT(OC3)" # USB3/2 Type A upper Move to tcss_xhci PCI device