Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35456 )
Change subject: sconfig: Allow to link devices to other device' drivers
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35456/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35456/4//COMMIT_MSG@32
PS4, Line 32: use my_eeprom as needed_eeprom
What about just keeping `register` for this? It would still require a different token but it still k […]
It would have to be the other way around `register "needed_eeprom" ...`.
I don't care much, but would prefer a syntax that is more related to the
solution. If I had to decide today, I would probably use
dev needed_eeprom is my_eeprom
(having the config field on the left aligns better with the regular
assignments)
TBH, I hate the `register` keyword. I can only guess it's a relict from a
time when board ports were allowed to override actual register contents.
Today, I believe, it discourages to implement more abstract, high-level
configuration options.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35456
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I058a319f9b968924fbef9485a96c9e3f900a3ee8
Gerrit-Change-Number: 35456
Gerrit-PatchSet: 4
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Thu, 23 Jul 2020 21:29:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment