Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37486 )
Change subject: rules.h: Add ENV_EARLY_RAM ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37486/1/src/include/rules.h File src/include/rules.h:
https://review.coreboot.org/c/coreboot/+/37486/1/src/include/rules.h@259 PS1, Line 259: #define ENV_EARLY_RAM (ENV_ROMSTAGE_OR_BEFORE && CONFIG(RESET_VECTOR_IN_RAM)) Since all stages have mutable memory, we should have ENV_EARLY_RAM = !ENV_CACHE_AS_RAM, it is one or the other. Should we keep this, there should be an accompanying #define for !ARCH_X86.
But I don't see why we would need to add this, are there some if (ENV_EARLY_RAM) cases on your patchtrain?
I don't mind if you rename RESET_VECTOR_IN_RAM, looking at the direction things are going, I believe we can do this all with a single Kconfig that acts as a selector between car.ld and early_ram.ld and then use it elsewhere.
https://review.coreboot.org/c/coreboot/+/37486/1/src/include/rules.h@261 PS1, Line 261: #define ENV_STAGE_HAS_DATA_SECTION (!ENV_CACHE_AS_RAM && !ENV_EARLY_RAM) I don't see why you would need to restrict this. Aaron has also suggested to add .data to car.ld and I would welcome that change.