Xixi Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46585 )
Change subject: soc/mediatek/mt8192: add dram log prefix ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/c/coreboot/+/46585/2/src/soc/mediatek/mt8192/Kco... File src/soc/mediatek/mt8192/Kconfig:
PS2:
Thank you for the quick response for the comments in [1]. […]
Ack
https://review.coreboot.org/c/coreboot/+/46585/2/src/soc/mediatek/mt8192/Kco... PS2, Line 36: low, : medium and high
I thought we have 7 different frequencies in mt8192.
Yes, 8192 contains 7 freqs. "low, medium and high" means some freqs, not only one freq. Add freqs example to clear misunderstanding.
https://review.coreboot.org/c/coreboot/+/46585/2/src/soc/mediatek/mt8192/Kco... PS2, Line 43: will do
enables
Ack
https://review.coreboot.org/c/coreboot/+/46585/2/src/soc/mediatek/mt8192/Kco... PS2, Line 44: expect
expected
Ack
https://review.coreboot.org/c/coreboot/+/46585/2/src/soc/mediatek/mt8192/mem... File src/soc/mediatek/mt8192/memory.c:
https://review.coreboot.org/c/coreboot/+/46585/2/src/soc/mediatek/mt8192/mem... PS2, Line 24: printk(BIOS_ERR, "[MEM] DRAM memory test failed: %d\n", result);
How about we print only one message regardless of the test result? […]
Ack