Bryant Ou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42856 )
Change subject: mb/ocp/deltalake: Enable LPC IO 0x600 decode for BIC ......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/c/coreboot/+/42856/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42856/1//COMMIT_MSG@9 PS1, Line 9: it
uses
Done
https://review.coreboot.org/c/coreboot/+/42856/1//COMMIT_MSG@9 PS1, Line 9: use
uses
Done
https://review.coreboot.org/c/coreboot/+/42856/1//COMMIT_MSG@10 PS1, Line 10: bridge IC
What's a "bridge IC"? Is it a BMC, or is it another kind of chip?
Yes, it's another chip.
https://review.coreboot.org/c/coreboot/+/42856/1//COMMIT_MSG@10 PS1, Line 10: form
from
Done
https://review.coreboot.org/c/coreboot/+/42856/1/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/42856/1/src/mainboard/ocp/deltalake... PS1, Line 40: 0x00FC0601
nit: since the value below is in lowercase, make this one lowercase too?
Done