build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47705 )
Change subject: mb/google/volteer/var/elemi: Update gpio ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/c/coreboot/+/47705/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/elemi/gpio.c:
https://review.coreboot.org/c/coreboot/+/47705/1/src/mainboard/google/voltee... PS1, Line 185: /* B2 : VRALERT# ==> EN_PP3300_SSD */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/47705/1/src/mainboard/google/voltee... PS1, Line 186: PAD_CFG_GPO(GPP_B2, 1, DEEP), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/47705/1/src/mainboard/google/voltee... PS1, Line 186: PAD_CFG_GPO(GPP_B2, 1, DEEP), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47705/1/src/mainboard/google/voltee... PS1, Line 187: /* B4 : CPU_GP3==> EN_PP3300_EMMC */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/47705/1/src/mainboard/google/voltee... PS1, Line 188: PAD_CFG_GPO(GPP_B4, 1, DEEP), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/47705/1/src/mainboard/google/voltee... PS1, Line 188: PAD_CFG_GPO(GPP_B4, 1, DEEP), please, no spaces at the start of a line