[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake/chip: Unhide P2SB device

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35620 )

Change subject: soc/intel/skylake/chip: Unhide P2SB device
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35620/2/src/soc/intel/skylake/chip_... 
File src/soc/intel/skylake/chip_fsp20.c:

https://review.coreboot.org/c/coreboot/+/35620/2/src/soc/intel/skylake/chip_... 
PS2, Line 184: p2sb_unhide
> https://github.com/coreboot/coreboot/blob/master/src/soc/intel/skylake/final... […]

on core platform, i remember to have some recommendation that FSP-S should make p2sb hidden and then if CB like to use it then just unhide and make sure before booting to OS ,we are hiding p2sb again.

looks like src/soc/intel/common/block/systemagent/systemagent.c will eventually make p2sb hidden so we are good to meet the recommendation.

i got confused with commit msg saying unhide p2sb, but looks like thats is intermediate one to bypass warning