Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42947 )
Change subject: doc/mb/ocp: Add documentation for Delta Lake ......................................................................
Patch Set 1:
(6 comments)
Thanks for the review!
https://review.coreboot.org/c/coreboot/+/42947/1/Documentation/mainboard/ocp... File Documentation/mainboard/ocp/deltalake.md:
https://review.coreboot.org/c/coreboot/+/42947/1/Documentation/mainboard/ocp... PS1, Line 51: kernel versions tried is 5.2.9. The initramfs image is u-root.
version […]
Done
https://review.coreboot.org/c/coreboot/+/42947/1/Documentation/mainboard/ocp... PS1, Line 62: - Skipping memory training upon subsequent reboots
fantastic.
Done
https://review.coreboot.org/c/coreboot/+/42947/1/Documentation/mainboard/ocp... PS1, Line 67: [ChromeOS VPD] is used to store most of firmware configurations. RO_VPD
most of the firmware configurations.
Done
https://review.coreboot.org/c/coreboot/+/42947/1/Documentation/mainboard/ocp... PS1, Line 80: - ME based power capping.
capping is ... […]
This is a bug in ME. Filed ticket with Intel ME team. Will update the text.
https://review.coreboot.org/c/coreboot/+/42947/1/Documentation/mainboard/ocp... PS1, Line 88: | BMC | Aspeed AST 2500 |
complete with the embedded well known password :-)?
I am sorry, I am not sure I understand the comment and what needs to be changed.
https://review.coreboot.org/c/coreboot/+/42947/1/Documentation/mainboard/ocp... PS1, Line 94: [OCP]: https://www.opencompute.org
nice links!
Done