9 Nov
2020
9 Nov
'20
7:57 a.m.
Nicolas Boichat has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47287 )
Change subject: WIP: load spm firmware from cbfs ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47287/6/src/soc/mediatek/mt8192/spm... File src/soc/mediatek/mt8192/spm.c:
https://review.coreboot.org/c/coreboot/+/47287/6/src/soc/mediatek/mt8192/spm... PS6, Line 515: write32(&mtk_spm->md32pcm_dma0_start, MD32PCM_DMA0_START_VAL);
I think it's wise to add […]
Sorry, comment belong in https://review.coreboot.org/c/coreboot/+/46389/16
--
To view, visit https://review.coreboot.org/c/coreboot/+/47287
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I563c2d959cc2b597fee137ef1c53ee028e3c20c0
Gerrit-Change-Number: 47287
Gerrit-PatchSet: 6
Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nicolas Boichat drinkcat@chromium.org
Gerrit-Comment-Date: Mon, 09 Nov 2020 07:57:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nicolas Boichat drinkcat@chromium.org
Gerrit-MessageType: comment