Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48806 )
Change subject: mb/prodrive/hermes: Define board settings in EEPROM ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48806/1/src/mainboard/prodrive/herm... File src/mainboard/prodrive/hermes/eeprom.c:
https://review.coreboot.org/c/coreboot/+/48806/1/src/mainboard/prodrive/herm... PS1, Line 42: if (read_write_config(board_cfg, EEPROM_OFFSET_BOARD_SETTINGS, 0, sizeof(*board_cfg))) {
get_board_settings_from_eeprom should cache board_cfg and CRC valid, not the caller
Yeah, I agree. However, this file is built for romstage as well. I didn't try, but I might run into trouble with the illegal_globals check.