Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Karthik Ramasubramanian. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58899 )
Change subject: [RFC] ChromeOS: Add DECLARE_x_CROS_GPIOS() ......................................................................
Patch Set 5:
(4 comments)
File src/vendorcode/google/chromeos/chromeos.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132402): https://review.coreboot.org/c/coreboot/+/58899/comment/9f501a35_65284148 PS5, Line 103: #define DECLARE_CROS_GPIOS(x) \ Macros with flow control statements should be avoided
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132402): https://review.coreboot.org/c/coreboot/+/58899/comment/5c13a70f_3c99b046 PS5, Line 104: const struct cros_gpio *variant_cros_gpios(size_t *num) \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132402): https://review.coreboot.org/c/coreboot/+/58899/comment/4a67c0a8_791b5ba8 PS5, Line 110: #define DECLARE_WEAK_CROS_GPIOS(x) \ Macros with flow control statements should be avoided
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132402): https://review.coreboot.org/c/coreboot/+/58899/comment/40e07f4c_79d1342e PS5, Line 111: const struct cros_gpio *__weak variant_cros_gpios(size_t *num) \ please, no space before tabs