Attention is currently required from: Martin L Roth, Patrick Georgi, David Hendricks, Paul Menzel, Angel Pons, ron minnich.
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64724 )
Change subject: intelp2m: Add Go Managing Dependencies System support ......................................................................
Patch Set 5:
(1 comment)
File util/intelp2m/go.mod:
https://review.coreboot.org/c/coreboot/+/64724/comment/1dc09753_d436247f PS1, Line 1: github.com
This has been tested with an internal git repository.
+ some tests:
1) import the coreboot project into some go project: $cd path/to/any-go-project $go get review.coreboot.org/coreboot.git go: downloading review.coreboot.org/coreboot.git v0.0.0-20220903004133-39914a50ae16 go: added review.coreboot.org/coreboot.git v0.0.0-20220903004133-39914a50ae16
Thus, 'go get' correctly downloaded the contents of the coreboot repository.
2) import intelp2m: $cd path/to/any-go-project $go get review.coreboot.org/coreboot.git/util/intelp2m review.coreboot.org/coreboot.git/util/intelp2m imports ./config: "./config" is relative, but relative import paths are not supported in module mode review.coreboot.org/coreboot.git/util/intelp2m imports ./parser: "./parser" is relative, but relative import paths are not supported in module mode
so the problem is in the package names, but after this patch, the import should be without errors;
3) import a repository with an incorrect url: $cd path/to/any-go-project $go get review.coreboot.org/coreboot/test go: unrecognized import path "review.coreboot.org/coreboot/test": reading https://review.coreboot.org/coreboot/test?go-get=1: 404 Not Found
This has not happened in previous cases.