Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31262 )
Change subject: soc/intel/cannonlake: Add field to identify single channel skus
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/31262/5/src/soc/intel/cannonlake/cnl_memcfg_...
File src/soc/intel/cannonlake/cnl_memcfg_init.c:
https://review.coreboot.org/#/c/31262/5/src/soc/intel/cannonlake/cnl_memcfg_...
PS5, Line 20: #include <soc/gpio_soc_defs.h>
I think you need to include soc/gpio. […]
Thanks a lot, Furquan. This fixed things.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31262
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ice22b103664187834e255d1359bfd9b51993b5b6
Gerrit-Change-Number: 31262
Gerrit-PatchSet: 6
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aamir Bohra
aamir.bohra@intel.com
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Duncan Laurie
dlaurie@chromium.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Comment-Date: Mon, 11 Feb 2019 22:26:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment