Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40244 )
Change subject: soc/tigerlake: Add devicetree configurability for IomTypeCPortPadCfg
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40244/1/src/soc/intel/tigerlake/fsp...
File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/40244/1/src/soc/intel/tigerlake/fsp...
PS1, Line 98: 0x09000000
I think should be set to all 0s. […]
good point...we can address this after the rest though correct? I think the 0x09000000 is default setting here and we haven't really done any testing setting this to 0. I can make this change as a separate patch that doesn't rely on the rest of the Aux orientation stuff
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40244
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2e48adb624c7922170eafb8dfcaed680f008936e
Gerrit-Change-Number: 40244
Gerrit-PatchSet: 1
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 07 Apr 2020 21:44:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment