Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39866 )
Change subject: soc/intel/tigerlake: Add macros and SPD information for DDR4
......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39866/11/src/soc/intel/tigerlake/in...
File src/soc/intel/tigerlake/include/soc/meminit.h:
https://review.coreboot.org/c/coreboot/+/39866/11/src/soc/intel/tigerlake/in...
PS11, Line 25: s(
nit: space
Done
https://review.coreboot.org/c/coreboot/+/39866/11/src/soc/intel/tigerlake/in...
PS11, Line 54: SMBUS
addr_dimmN or say leave the smbus address as 0?
Woops. Thanks for catching that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39866
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4b565c3d71bbf437da64ac29597cc19e58f1b98a
Gerrit-Change-Number: 39866
Gerrit-PatchSet: 11
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Varun Joshi
varun.joshi@intel.com
Gerrit-Reviewer: Varun Joshi
varun.joshi@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Selma Bensaid
selma.bensaid@intel.com
Gerrit-CC: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Comment-Date: Wed, 01 Apr 2020 22:39:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment