[coreboot-gerrit] Change in ...coreboot[master]: mb/google/hatch: Add GPIO_A8 for Pen detect function

[Dtrain Hsu (Code Review)]

Dtrain Hsu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31815

Change subject: mb/google/hatch: Add GPIO_A8 for Pen detect function
......................................................................

mb/google/hatch: Add GPIO_A8 for Pen detect function

Add GPIO_A8 for pen detect function.

BUG=b:122765828
TEST=flash BIOS and using switch to verify GPIO_A8 value change.

Signed-off-by: Dtrain Hsu 
Change-Id: Ie7c888ea61dd61e60c1d184565bd95e6b03777be
---
M src/mainboard/google/hatch/Kconfig
M src/mainboard/google/hatch/variants/baseboard/devicetree.cb
M src/mainboard/google/hatch/variants/baseboard/gpio.c
3 files changed, 14 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/31815/1

diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig
index 2290d8c..8e9ab9c 100644
--- a/src/mainboard/google/hatch/Kconfig
+++ b/src/mainboard/google/hatch/Kconfig
@@ -6,6 +6,7 @@
    select DRIVERS_I2C_HID
    select DRIVERS_SPI_ACPI
    select DRIVERS_USB_ACPI
+        select DRIVERS_GENERIC_GPIO_KEYS
    select EC_GOOGLE_CHROMEEC
    select EC_GOOGLE_CHROMEEC_LPC
    select HAVE_ACPI_RESUME
diff --git a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb
index e2c3392..885105e 100644
--- a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb
+++ b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb
@@ -220,7 +220,17 @@
    			device i2c 49 on end
    		end
    	end # I2C #1
-		device pci 15.2 on  end # I2C #2
+		device pci 15.2 on
+                        chip drivers/generic/gpio_keys
+                                register "name" = ""PENH""
+                                register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(GPP_A8)"
+                                register "key.dev_name" = ""EJCT""
+                                register "key.linux_code" = "SW_PEN_INSERTED"
+                                register "key.linux_input_type" = "EV_SW"
+                                register "key.label" = ""pen_eject""
+                                device generic 0 on end
+                        end
+                end # I2C #2
    	device pci 15.3 on  end # I2C #3
    	device pci 16.0 on  end # Management Engine Interface 1
    	device pci 16.1 off end # Management Engine Interface 2
diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c
index 35dd912..d66328b 100644
--- a/src/mainboard/google/hatch/variants/baseboard/gpio.c
+++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c
@@ -30,8 +30,8 @@
    PAD_CFG_GPI_APIC(GPP_A6, NONE, DEEP, LEVEL, NONE),
    /* A7  : PP3300_SOC_A */
    PAD_NC(GPP_A7, NONE),
-	/* A8  : EMR_GARAGE_DET ==> NC */
-	PAD_NC(GPP_A8, NONE),
+	/* A8  : PEN_EJECT(notifications)  */
+	PAD_CFG_GPI_GPIO_DRIVER(GPP_A8, UP_20K, DEEP),
    /* A9  : ESPI_CLK */
    /* A10 : PEN_RESET_ODL */
    PAD_NC(GPP_A10, NONE),