2 Jul
2019
2 Jul
'19
1:21 p.m.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33953 )
Change subject: mb/google/hatch/variants/helios: Update Spd sources ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/33953/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33953/1//COMMIT_MSG@7 PS1, Line 7: Spd SPD
https://review.coreboot.org/#/c/33953/1//COMMIT_MSG@9 PS1, Line 9: Add SPD_SOURCES "empty_ddr4", "LP_8G_2133" and "LP_16G_2133" to Makefile.inc. Please add the motivation for this change to the commit messages. Why is empty_ddr4 needed for example?
--
To view, visit https://review.coreboot.org/c/coreboot/+/33953
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9cb4e46c7c4da72d8fb029f1b8e8c3b06d1ab156
Gerrit-Change-Number: 33953
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Chu frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Frank Chu frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org
Gerrit-Reviewer: Philip Chen philipchen@google.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-CC: Kane Chen kane_chen@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 02 Jul 2019 11:21:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment