Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34233 )
Change subject: src: Use 'include <gpio.h>' when appropriate
......................................................................
Patch Set 4:
by the way, I got this error :
/cb-build/coreboot-gerrit.0/GOOGLE_NYAN_BIG/mainboard/google/nyan_big/static.c:14:29: error: 'P2' undeclared here (not in a function)
.backlight_vdd_gpio = GPIO(H2),"
and didn't found where 'H2' is defined ....
The problem is that it doesn't have the GPIO() macro (and therefore thinks it's a function, and therefore thinks the thing inside the parenthesis was a normal identifier, which it isn't). You shouldn't remove it from any chip.h headers, those are special (because they get included in the runtime-generated code from sconfig).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34233
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I570c6fcc889b37297fed7f1e252de1ff1ff632fb
Gerrit-Change-Number: 34233
Gerrit-PatchSet: 4
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 11 Jul 2019 18:01:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment