Attention is currently required from: Caveh Jalali, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, Mark Hsieh.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55735 )
Change subject: mb/google/brya: add generic LPDDR4 SPDs for Gimble
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/variants/gimble/memory/dram_id.generated.txt:
https://review.coreboot.org/c/coreboot/+/55735/comment/cebe4948_3a08ca7e
PS3, Line 4: H9HCNNNBKMMLXR-NEE 0 (0000)
nit: any reason not to sort the entries in ascending ID order? […]
This file is auto-generated based on the memory parts added to the mem_list_variant.txt: https://review.coreboot.org/c/coreboot/+/55735/3/src/mainboard/google/brya/v...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55735
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I60f95ac5ed7f3134882f6580335ec33632676796
Gerrit-Change-Number: 55735
Gerrit-PatchSet: 3
Gerrit-Owner: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Ariel Fang
ariel_fang@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-Comment-Date: Tue, 22 Jun 2021 16:31:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment