Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47545 )
Change subject: mb/amd/mandolin: Add decode range for LPC debug card ......................................................................
Patch Set 3:
(2 comments)
this one needs a manual rebase, since I've fixed the comment on AMD_LPC_DEBUG_CARD in the meantime and I think that we shold still mention that this option is mutually exclusive with PICASSO_CONSOLE_UART
https://review.coreboot.org/c/coreboot/+/47545/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47545/3//COMMIT_MSG@9 PS3, Line 9: Newer i'm not sure if this is only for the newer ones or if that's for all amd lpc serial port cards. for debugging a system without needing to change other things, it does make sense that it uses a non-standard address, so it won't collide with the main super i/o in the system
https://review.coreboot.org/c/coreboot/+/47545/3/src/mainboard/amd/mandolin/... File src/mainboard/amd/mandolin/bootblock.c:
https://review.coreboot.org/c/coreboot/+/47545/3/src/mainboard/amd/mandolin/... PS3, Line 15: RANGE i'd call it _BASE instead of _RANGE