[coreboot-gerrit] Change in coreboot[master]: cpu/x86/mp_init.c: Add wait_finished_mp_run_on_all_cpus

[Kane Chen (Code Review)]

Attention is currently required from: Arthur Heymans, Subrata Banik, Tim Wawrzynczak.
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63566 )

Change subject: cpu/x86/mp_init.c: Add wait_finished_mp_run_on_all_cpus
......................................................................

Patch Set 7:

(3 comments)

File src/cpu/x86/mp_init.c:

https://review.coreboot.org/c/coreboot/+/63566/comment/7fe2d921_61410720 
PS5, Line 932: 			if (atomic_read(&ap_busy[i]) == -1)
             : 				cpus_finish++;
> > Instead of using 0/1 for busy/not busy, this patchset use 1 and -1 to indicate busy/not busy becau […]

i init the array with AP_NOT_BUSY in the beginning of ap_wait_for_instruction and it's after mp_init.
Hopefully, it's acceptable because it's more clear where the array should be init

https://review.coreboot.org/c/coreboot/+/63566/comment/5690c3bb_19c7b254 
PS5, Line 977: atomic_set(&ap_busy[cur_cpu], 1);
> Probably best to add a comment that this needs to happen before storing NULL to the callback as the  […]

done

https://review.coreboot.org/c/coreboot/+/63566/comment/613775e0_ead42227 
PS5, Line 985: goto finish;
> Reverse the if condition and avoid goto.

done