22 Apr
2021
22 Apr
'21
8:09 a.m.
Attention is currently required from: Nico Huber, Angel Pons. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49204 )
Change subject: console/vtxprintf.c: Use same indents for switch/case ......................................................................
Patch Set 8:
(1 comment)
File src/console/vtxprintf.c:
https://review.coreboot.org/c/coreboot/+/49204/comment/206bb9cc_ca666f12 PS2, Line 134: case '0': flags |= ZEROPAD; goto repeat;
That's the problem, right? If we have reasons to +2 either direction, […]
So, what's the conclusion here? Running in circles or not?
--
To view, visit https://review.coreboot.org/c/coreboot/+/49204
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13c723c335d18bbdd2dcb041f44b187df6c5d728
Gerrit-Change-Number: 49204
Gerrit-PatchSet: 8
Gerrit-Owner: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 22 Apr 2021 06:09:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment